Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make sync-playwright command visible #924

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

ferrandiaz
Copy link
Contributor

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

npx checkly help now shows sync-playwright command

@ferrandiaz ferrandiaz requested review from tnolet and clample January 19, 2024 11:12
tnolet
tnolet previously approved these changes Jan 19, 2024
Copy link
Member

@tnolet tnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferrandiaz ferrandiaz force-pushed the ferran/remove-hidden-sync-playwright branch 2 times, most recently from c996c7c to 6f4a41b Compare January 19, 2024 11:51
@ferrandiaz ferrandiaz force-pushed the ferran/remove-hidden-sync-playwright branch from 6f4a41b to 6c4955a Compare January 19, 2024 13:12
@ferrandiaz ferrandiaz requested a review from tnolet January 19, 2024 13:33
Copy link
Member

@tnolet tnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferrandiaz ferrandiaz merged commit c5af9b2 into main Jan 19, 2024
3 checks passed
@ferrandiaz ferrandiaz deleted the ferran/remove-hidden-sync-playwright branch January 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants