chore: allow testing multiple prereleases #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clample
force-pushed
the
chrislample/update-release-job
branch
from
0119860 to
15ad3fc
Compare
clample
force-pushed
the
chrislample/update-release-job
branch
from
15ad3fc to
47451f9
Compare
ferrandiaz
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components
Notes for the Reviewer
The release.yml job already pushes pre-releases to NPM so that we can do some extra testing. The problem is that if we find an issue, it's hard to reset everything: NPM doesn't allow us to unpublish the prerelease and we can't overwrite it either.
This PR adds the commit SHA to the prerelease version. If we detect an issue in the prerelease phase, we can delete the Github release, fix the issue, and trigger another release.
This PR will also automatically push the
vtag with the release, since that has been causing issues for oldcreate-checklyversions.