Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added TS types for http proxy - [sc-22386] #982

Merged
merged 1 commit into from
Nov 26, 2024
Merged

feat: added TS types for http proxy - [sc-22386] #982

merged 1 commit into from
Nov 26, 2024

Conversation

ejanusevicius
Copy link
Contributor

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

  • Adds the TypeScript type for HttpProxy that complies with Playwright documentation here.

ferrandiaz
ferrandiaz approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ferrandiaz ferrandiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejanusevicius ejanusevicius merged commit 0c49535 into main Nov 26, 2024
3 checks passed
@ejanusevicius ejanusevicius deleted the edvinasjanueviius/sc-22386/support-proxy-field-in-playwright-config branch November 26, 2024 13:27
@ejanusevicius ejanusevicius mentioned this pull request Nov 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrandiaz ferrandiaz ferrandiaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejanusevicius @ferrandiaz