Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webhook secret support for webhook alert channels [sc-22462] #985

Conversation

sorccu
Copy link
Contributor

@sorccu sorccu commented Nov 27, 2024

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Resolves #[issue-number]

New Dependency Submission

Hardly a true test for whether the secret really gets set or not, but it's
in line with the current tests.
@sorccu sorccu merged commit 43bf5ac into main Nov 28, 2024
3 checks passed
@sorccu sorccu deleted the simokinnunen/sc-22462/add-secret-support-for-webhook-alert-channels branch November 28, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant