Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document RetryStrategyBuilder.noRetries() #1001

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

clample
Copy link
Contributor

@clample clample commented Mar 25, 2024

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

The CLI now supports RetryStrategyBuilder.noRetries() to disable the default retry strategy (introduced in CLI 4.6.3 with checkly/checkly-cli#944).

I'm not sure there's a better way to rephrase the following sentence, since noRetries() doesn't take an options argument:

For all of the methods above, the options argument can be used to customize the following properties:

@clample clample requested a review from tnolet as a code owner March 25, 2024 15:12
Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 3:17pm

Copy link
Member

@tnolet tnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clample clample merged commit ad6c297 into main Mar 25, 2024
6 checks passed
@clample clample deleted the chrislample/document-cli-no-retries branch March 25, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants