Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize prompts #33

Merged
merged 22 commits into from
Feb 6, 2025
Merged

Organize prompts #33

merged 22 commits into from
Feb 6, 2025

Conversation

azer
Copy link
Collaborator

@azer azer commented Feb 5, 2025

No description provided.

@azer azer changed the title [WIP] Organize prompts Organize prompts Feb 5, 2025
Copy link
Member

@jan-osch jan-osch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good so far. Let's use the extracted prompts in Tools

import { LanguageModelV1 } from "ai";

export const model = openai("gpt-4o");
export const temperature = 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, just learned about temperature, can you add a tiny explainer why 0 is the best choice for our case?

Copy link
Collaborator Author

@azer azer Feb 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was initially the default temperature value but we're actually not using it anymore.

src/prompts/sre-assistant.ts Outdated Show resolved Hide resolved
];
}

export function generateTimeframePrompt(): [string, PromptConfig] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's not yet used in the tool

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-osch used by src/github/agent.ts

src/prompts/github.ts Outdated Show resolved Hide resolved
@azer azer requested a review from jan-osch February 6, 2025 10:33
Copy link
Member

@jan-osch jan-osch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jan-osch jan-osch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jan-osch jan-osch merged commit 2e50df2 into main Feb 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants