ci: fix docker test #2302
Merged
ci: fix docker test #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember there was quite a protest from vz guys for bashisms as they don't have bash in the testing setup (?). Just for curiosity: is it also fixed by pre-initializing |
|
@0x7f454c46 I remember I was to tired with all these shellshit and replaced /bin/sh with /bin/bash everywhere, so bash is required to run tests. |
avagin
reviewed
Nov 28, 2023
rst0git
force-pushed
the
ci-docker-test-fix
branch
3 times, most recently
from
f65e10c to
be9a9fa
Compare
rst0git
force-pushed
the
ci-docker-test-fix
branch
2 times, most recently
from
c527e90 to
bd16e3e
Compare
Replace a recursive call with a loop. Reported-by: Andrei Vagin <[email protected]> Signed-off-by: Radostin Stoyanov <[email protected]>
rst0git
force-pushed
the
ci-docker-test-fix
branch
from
bd16e3e to
c04efaa
Compare
Checkpoint/restore with version 25.0.0-beta.1 fails with the following error: $ docker start --checkpoint=c1 cr Error response from daemon: failed to create task for container: content digest fdb1054b00a8c07f08574ce52198c5501d1f552b6a5fb46105c688c70a9acb45: not found: unknown Release notes: moby/moby#46816 Signed-off-by: Radostin Stoyanov <[email protected]>
rst0git
force-pushed
the
ci-docker-test-fix
branch
from
c04efaa to
1ccbfe4
Compare
Thanks for the note, I was not aware of it =) But I know for sure that we don't run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of docker-ce on Ubuntu 20.04 has been recently updated to 25.0.0-beta.1. However, with this version
docker start --checkpointfails with the following error:As a workaround, we install the most recent stable version of docker-ce. In addition, to improve code readability, the recursive function call used for retrying container restoration has been replaced with a loop.