optimize: added a tail pointer in mntinfo_add_list #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avagin
reviewed
Feb 7, 2025
criu/mount.c
Outdated
| void mntinfo_add_list_before(struct mount_info **head, struct mount_info *new) | ||
| { | ||
| new->next = *head; | ||
| if(!*head) |
avagin
reviewed
Feb 7, 2025
| @@ -90,6 +90,7 @@ struct mount_info { | |||
| int deleted_level; | |||
| struct list_head deleted_list; | |||
| struct mount_info *next; | |||
| struct mount_info *tail; | |||
There was a problem hiding this comment.
I think it is better to user the list_head structure here.
avagin
reviewed
Feb 7, 2025
criu/mount.c
Outdated
| @@ -1959,7 +1959,7 @@ static int dump_mnt_ns(struct ns_id *ns, struct mount_info *pms) | |||
| _mi = list_entry(_mi->children._el, struct mount_info, siblings); \ | |||
| continue; \ | |||
| } \ | |||
| up: \ | |||
| up: \ | |||
There was a problem hiding this comment.
you should not change unrelated code...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mntinfo_add_list function previously traversed the entire linked list to find the tail node, resulting in a time complexity of O(n). This commit introduces a mntinfo_tail pointer to track the last node of the list, reducing the time complexity of insertion to O(1).