Moving prop-types to dependencies #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although prop-types is meant to run only on development environments, it still is a package required in production code. Having prop-types under devDependencies means that whoever wants to use react-lottie will get a module not found error for it. Also the recomendation from prop-types team is to add their package as dependencies not devDependencies. You can see this on "How to Depend on This Package?" section on their npm page https://www.npmjs.com/package/prop-types
|
I've created a fork and a new package for this project as it seems dead. I've added this change to it: https://www.npmjs.com/package/lottie-jsx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although prop-types is meant to run only on development environments, it still is a package required in production code.
Having prop-types under devDependencies means that whoever wants to use react-lottie will get a module not found error for it. Also the recomendation from prop-types team is to add their package as dependencies not devDependencies. You can see this on "How to Depend on This Package?" section on their npm page https://www.npmjs.com/package/prop-types