Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Twisted Trac ticket migration script #23

Merged
merged 17 commits into from
Jul 1, 2022
Merged

Adapt Twisted Trac ticket migration script #23

merged 17 commits into from
Jul 1, 2022

Conversation

danuker
Copy link
Contributor

@danuker danuker commented Apr 11, 2022

Fixes #17
See also: #16

Importing the 8 sample tickets took 3 minutes (2.666 tickets/minute; all Twisted tickets would take 64.66 hours if the sample is representative)

Changes:

Checkboxes for a lot of details
  • status change history
    • include status changes and changers
    • include owner changes
    • merge comments/statuschanges occurring at the same time
  • Check API to notify subscribed users on GitHub, based on CC field There is no field for adding subscribers, neither with the Import API, nor with the slow API.
  • remove emails from CC field (example) Consider using cc__user1 cc__user2 as searchable keywords, but do not give out email domains. That way, users can search for cc__themselves and manually subscribe.
  • description must have date of creation (not just modified)
  • fix "Replying to ___" links from comments - Added a comment anchor.
  • Create and reuse GitHub milestones from Trac milestones
  • GitHub mapping of top users (ask permission from them?)
    • may automatically map those with oauth_state
    • remove @ GitHub mention for those without oauth_state
    • looks like not a lot of users have an oauth_state session_attribute: select author, count(author), name from ticket_change left join session_attribute on author=sid and name='oauth_state' group by author order by count(*) desc;
  • Create labels for all the "fixed" metadata - see Preserve all trac ticket metadata in machine readable form #17
  • Create "bug" label for tickets of type "bug" (as opposed to Trac "task")
  • Check what else applies from Story: Perform Twisted ticket migration #16
  • Consider treating CommitTicketReferences Ugly but works already.
    • Unquote the large commit hash, so it's an easier to click link
  • Remove extraneous punctuation
  • Fix mentioning unknown users (but still attempt USER_MAPPING first).
  • Link directly to the new expected GitHub URLs ticket IDs (i.e. just #1234). This has the advantage that the redirect is not needed, but if someone creates a ticket or PR during the import, the already-imported tickets might link to it, wrongly. Should happen already after generating tickets_expected_gold.tsv with the target ticket IDs. Will check in twisted/twisted-trac-migration.

reviewers: @adiroiban

Here are some sample outputs generated by commit 89a0d66. If you want more, ask me.

@danuker danuker changed the title [#17] Adding fields to description. [#17] WIP: Adding fields to description. Apr 11, 2022
@danuker danuker self-assigned this Apr 13, 2022
@danuker danuker changed the title [#17] WIP: Adding fields to description. [#17] Adding fields to description. May 19, 2022
@danuker
Copy link
Contributor Author

danuker commented May 20, 2022

needs-review

@danuker
Copy link
Contributor Author

danuker commented May 20, 2022

needs-changes

  • Must use #1234 syntax instead of trac#1234, with the predicted ticket IDs instead of the old Trac IDs.
  • Must unquote the large commit hash for a CommitTicketReference, so it's an easier to click link

@chevah-robot chevah-robot assigned danuker and unassigned adiroiban May 20, 2022
@danuker danuker changed the title [#17] Adding fields to description. [#17] Handle Twisted Trac tickets migration to GitHub Issues May 20, 2022
@danuker danuker changed the title [#17] Handle Twisted Trac tickets migration to GitHub Issues Handle Twisted Trac tickets migration to GitHub Issues May 20, 2022
@danuker danuker changed the title Handle Twisted Trac tickets migration to GitHub Issues Adapt Twisted Trac ticket migration script May 24, 2022
@danuker danuker merged commit f7f9c35 into main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve all trac ticket metadata in machine readable form
3 participants