-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Twisted Trac ticket migration script #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs-review |
needs-changes
|
Also linkify changeset hashes and leave alone missing IDs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
See also: #16
Importing the 8 sample tickets took 3 minutes (2.666 tickets/minute; all Twisted tickets would take 64.66 hours if the sample is representative)
Changes:
Checkboxes for a lot of details
Check API to notify subscribed users on GitHub, based on CC fieldThere is no field for adding subscribers, neither with the Import API, nor with the slow API.remove emails from CC field (example)Consider using cc__user1 cc__user2 as searchable keywords, but do not give out email domains. That way, users can search forcc__themselves
and manually subscribe.@
GitHub mention for those without oauth_stateoauth_state
session_attribute
:select author, count(author), name from ticket_change left join session_attribute on author=sid and name='oauth_state' group by author order by count(*) desc;
Consider treating CommitTicketReferencesUgly but works already.USER_MAPPING
first).Link directly to the new expectedShould happen already after generatingGitHub URLsticket IDs (i.e. just #1234). This has the advantage that the redirect is not needed, but if someone creates a ticket or PR during the import, the already-imported tickets might link to it, wrongly.tickets_expected_gold.tsv
with the target ticket IDs. Will check intwisted/twisted-trac-migration
.reviewers: @adiroiban
Here are some sample outputs generated by commit 89a0d66. If you want more, ask me.