Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine some apt line and update mLNHIICC version to 20220110 #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

combine some apt line and update mLNHIICC version to 20220110 #7

wants to merge 1 commit into from

Conversation

ifurther
Copy link

  • mLNHIICC 需要新版本的libc，所以升級基礎容器Ubuntu到20.04
  • 將所需的套件(包含mLNHIICC的)濃縮到一個階段可以減少容器使用空間
  • mLNHIICC新版改為用script安裝型式
  • 移除口罩地圖在start.sh的網址

bluet
bluet reviewed Aug 20, 2022
View reviewed changes
Copy link
Contributor

@bluet bluet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few styling suggestions

Dockerfile Outdated
# Setup timezone
RUN apt-get install -y tzdata \
&& ln -fs /usr/share/zoneinfo/Asia/Taipei /etc/localtime
RUN sed -e s%http://archive.ubuntu.com/ubuntu/%http://ftp.tku.edu.tw/ubuntu% -i /etc/apt/sources.list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

鎖定使用 ftp.tku 似乎不太適合

Dockerfile Outdated
&& apt-get install --no-install-recommends -y firefox ttf-wqy-microhei locales tzdata sudo pcscd pcsc-tools unbound-anchor libboost-all-dev libssl-dev libnss3-tools wget p11-kit\
&& locale-gen zh_TW zh_TW.UTF-8 zh_CN zh_CN.UTF-8 en \
&& ln -fs /usr/share/zoneinfo/Asia/Taipei /etc/localtime \
&& echo "firefox ALL=NOPASSWD: /bin/su, /etc/init.d/pcscd, /usr/sbin/pcscd, /usr/local/share/NHIICC/mLNHIICC" >> /etc/sudoers.d/firefox \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在不同 layer 分開處理不同類型的事情（分成不同的 RUN）會較好

Dockerfile Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluet bluet bluet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ifurther @bluet