Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Add documentation for new rule CPMR0076 #1107

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This adds the new rule for flagging Icon URLs that make use of GitHub or
RawGit URLs in the nuspec file.

This rule is not currently planned for Package Validator, but is useful
to have as it will be implemented in the Chocolatey Community Validator
extension.

Motivation and Context

To document rules that are implemented in Chocolatey Community Validation extension, and considered for Package Validator.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left-hand side)/
  • Menu structure has been updated

Related Issue

@AdmiringWorm AdmiringWorm self-assigned this Dec 5, 2024
@AdmiringWorm AdmiringWorm requested a review from gep13 December 5, 2024 13:35
@AdmiringWorm AdmiringWorm marked this pull request as ready for review December 5, 2024 13:35
This adds a new component that can be used to mark Package Validator
rules as not yet being implemented in Package Validator, but however has
been implemented in the Chocolatey Community Validation Extension.
This adds the new rule for flagging Icon URLs that make use of GitHub or
RawGit URLs in the nuspec file.

This rule is not currently planned for Package Validator, but is useful
to have as it will be implemented in the Chocolatey Community Validation
extension.
@ferventcoder
Copy link
Member

So this one is just waiting on changes to be reviewed and then merged?

@pauby pauby dismissed gep13’s stale review February 14, 2025 11:32

All changes have been addressed and the reviewer is on leave.

@pauby pauby merged commit 21f587a into chocolatey:master Feb 14, 2025
1 check passed
@AdmiringWorm AdmiringWorm deleted the cpmr0076 branch February 14, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants