Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add segwit slides #56

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add segwit slides #56

wants to merge 7 commits into from

Conversation

golmit
Copy link
Contributor

@golmit golmit commented Jun 16, 2021

Description

First version of the "SegWit and Transaction Malleability" slides.

Type of Change

  • Major feature (New files or assets, large changes to files)

Checklist:

  • I have performed a self-review of my own changes
  • I have made sure that any changed LaTeX files compile properly
  • I have assigned at least one reviewer

Copy link
Contributor

@dariothuerkauf dariothuerkauf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how you managed to build upon parts from previous lectures and extend them reasonably to get a profound understanding of Transaction Malleability and SegWit!

\end{figure}
\vspace{1em}

\uncover<2->{$\rightarrow$ The \texttt{scriptSig} is part of the transaction data and cannot be signed (self-referential).}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\uncover<2->{$\rightarrow$ The \texttt{scriptSig} is part of the transaction data and cannot be signed (self-referential).}
\uncover<2->{$\rightarrow$ The signature is part of the \texttt{scriptSig} and cannot sign itself (self-referential).}

\end{scriptsize}
\vspace{1em}
To the alternative:\\
\begin{scriptsize}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark 4d separately as OP_PUSHDATA2 ?

%%%

%%%
\begin{frame}{P2SH Embedded SegWit Transactions}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slide is not that intuitive, but probably will be clear if presented in the video.

\begin{column}{0.5\textwidth}
\uncover<3->{
\begin{align*}
W &= 3 \cdot (1 - \beta) bs(\texttt{all})\\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an explanation what "Beta" and "bs" is?
I think the derivation of the formula is not necessary but I don't understand how the "+1" occurs in the second line.

Copy link
Member

@schaer-unibas schaer-unibas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @golmit! What a fantastic slide deck! I particularly enjoyed the things you added in addition to the book and the callbacks to the earlier slide decks (forks, ECDSA and transaction example). Only very minor inputs. -> Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants