Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak(core/rdr): add missing CDoorExtension to pool table entries #3142

Closed
wants to merge 1 commit into from
Closed

tweak(core/rdr): add missing CDoorExtension to pool table entries #3142

wants to merge 1 commit into from

Conversation

outsider31000
Copy link
Contributor

Goal of this PR

adds the correct pool name to the table entries

This PR applies to the following area(s)

RedM

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added the RedM Issues/PRs related to RedM label Feb 7, 2025
brunosollar
brunosollar reviewed Feb 7, 2025
View reviewed changes
Copy link

@brunosollar brunosollar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the comma

@outsider31000
Copy link
Contributor Author

fixed thanks

@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Feb 7, 2025
@d22tny
Copy link

d22tny commented Feb 8, 2025

you should squash the commits, commiting for a comma is terrifying.

@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed invalid Requires changes before it's considered valid and can be (re)triaged triage Needs a preliminary assessment to determine the urgency and required action labels Feb 8, 2025
@outsider31000 outsider31000 mentioned this pull request Feb 10, 2025
Closed
@Nobelium-cfx
Copy link
Contributor

Closing because this change is already made in 8871b05

PS: Sorry, I just didn't notice this change at the time, so created my own. But thank you for creating the PR anyway!

@outsider31000 outsider31000 deleted the doors branch February 15, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunosollar brunosollar brunosollar left review comments

Assignees
No one assigned
Labels
invalid Requires changes before it's considered valid and can be (re)triaged RedM Issues/PRs related to RedM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@outsider31000 @d22tny @Nobelium-cfx @brunosollar