Add support for builds on HPE NonStop. #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change includes modifying Makefile so that CFLAGS can be overridden by an invoking Makefile or shell. It also modifies sandbox.h to support an older form of mktemp/mkdir supported on the NonStop platform. Fixes: clar-test#95 Signed-off-by: Randall S. Becker <[email protected]>
pks-t
reviewed
Aug 6, 2024
| @@ -16,7 +16,7 @@ TEST_DIRECTORY := $(abspath $(dir $(CURRENT_MAKEFILE))) | |||
| CLAR_PATH := $(dir $(TEST_DIRECTORY)) | |||
| CLAR_FIXTURE_PATH := $(TEST_DIRECTORY)/resources/ | |||
|
|
|||
| CFLAGS=-g -I.. -I. -Wall -DCLAR_FIXTURE_PATH=\"$(CLAR_FIXTURE_PATH)\" | |||
| CFLAGS?=-g -I.. -I. -Wall -DCLAR_FIXTURE_PATH=\"$(CLAR_FIXTURE_PATH)\" | |||
There was a problem hiding this comment.
@rsbeckerca Changing CFLAGS like this is somewhat orthogonal to the enablement of NonStop architectures. I also think that we need to be a bit more thorough here and not only make the CFLAGS overridable, but also split it up into CFLAGS and CPPFLAGS. The latter would then hold the -DCLAR_FIXTURE_PATH define such that overriding CFLAGS won't cause us to drop that necessary define.
Overall, I think we should move this change into a separate PR such that the enablement of NonStop in clar/sandbox.h can be merged faster.
gitster
pushed a commit
to gitster/git
that referenced
this pull request
Aug 6, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
gitster
pushed a commit
to gitster/git
that referenced
this pull request
Aug 8, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
gitster
pushed a commit
to git/git
that referenced
this pull request
Aug 13, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
gitster
pushed a commit
to gitster/git
that referenced
this pull request
Aug 15, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
gitster
pushed a commit
to git/git
that referenced
this pull request
Aug 16, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
dscho
pushed a commit
to dscho/git
that referenced
this pull request
Aug 16, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
pks-t
added a commit
to pks-t/git
that referenced
this pull request
Aug 20, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
pks-t
added a commit
to pks-t/git
that referenced
this pull request
Aug 20, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
pks-t
added a commit
to pks-t/git
that referenced
this pull request
Aug 20, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
pks-t
added a commit
to pks-t/git
that referenced
this pull request
Aug 20, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
pks-t
added a commit
to pks-t/git
that referenced
this pull request
Aug 20, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
pks-t
added a commit
to pks-t/git
that referenced
this pull request
Aug 20, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
pks-t
added a commit
to pks-t/git
that referenced
this pull request
Aug 20, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
pks-t
added a commit
to pks-t/git
that referenced
this pull request
Aug 20, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
pks-t
added a commit
to pks-t/git
that referenced
this pull request
Aug 20, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
pks-t
added a commit
to pks-t/git
that referenced
this pull request
Aug 20, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
gitster
pushed a commit
to git/git
that referenced
this pull request
Aug 20, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
pks-t
added a commit
to pks-t/git
that referenced
this pull request
Sep 3, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]>
gitster
pushed a commit
to git/git
that referenced
this pull request
Sep 3, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
gitster
pushed a commit
to git/git
that referenced
this pull request
Sep 4, 2024
The NonStop platform does not have `mkdtemp()` available, which we rely on in `build_sandbox_path()`. Fix this issue by using `mktemp()` and `mkdir()` instead on this platform. This has been cherry-picked from the upstream pull request at [1]. [1]: clar-test/clar#96 Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
|
The HPE NonStop changes have been cherry-picked and we have replaced Makefiles with CMake. So this can be closed now. |
|
Just as a note, CMake is not available on HPE NonStop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes modifying Makefile so that CFLAGS can be overridden by an invoking Makefile or shell. It also modifies sandbox.h to support an older form of mktemp/mkdir supported on the NonStop platform.
Fixes: #95