Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for builds on HPE NonStop. #96

Closed
wants to merge 1 commit into from
Closed

Add support for builds on HPE NonStop. #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions clar/sandbox.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,12 @@ static int build_sandbox_path(void)
if (_mktemp(_clar_path) == NULL)
return -1;

if (mkdir(_clar_path, 0700) != 0)
return -1;
#elif defined(__TANDEM)
if (mktemp(_clar_path) == NULL)
return -1;

if (mkdir(_clar_path, 0700) != 0)
return -1;
#elif defined(_WIN32)
Expand Down
2 changes: 1 addition & 1 deletion test/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ TEST_DIRECTORY := $(abspath $(dir $(CURRENT_MAKEFILE)))
CLAR_PATH := $(dir $(TEST_DIRECTORY))
CLAR_FIXTURE_PATH := $(TEST_DIRECTORY)/resources/

CFLAGS=-g -I.. -I. -Wall -DCLAR_FIXTURE_PATH=\"$(CLAR_FIXTURE_PATH)\"
CFLAGS?=-g -I.. -I. -Wall -DCLAR_FIXTURE_PATH=\"$(CLAR_FIXTURE_PATH)\"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsbeckerca Changing CFLAGS like this is somewhat orthogonal to the enablement of NonStop architectures. I also think that we need to be a bit more thorough here and not only make the CFLAGS overridable, but also split it up into CFLAGS and CPPFLAGS. The latter would then hold the -DCLAR_FIXTURE_PATH define such that overriding CFLAGS won't cause us to drop that necessary define.

Overall, I think we should move this change into a separate PR such that the enablement of NonStop in clar/sandbox.h can be merged faster.


.PHONY: clean

Expand Down
Loading