Handle failures more consistently via clar_abort()
#101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In almost all cases, a call to `clar_print_onabort()` is immediately followed by a call to `exit(-1)`. Add a new function `clar_abort()` that combines these two steps into one and convert callsites to use it. While at it, adapt the error messages to be consistent with trailing punctuation and newlines as well as more informative by including both potential arguments and the errno.
When initializing a summary fails we first call `perror()` followed by `clar_abort()`. This is somewhat broken because the second function call will always claim that opening the file has failed, even though the failure may actually be that we are out of memory. Fix this by using `clar_abort()` in `clar_summary_init()` directly, which gives direct access to the failures' root cause. Callers do not need to check for errors anymore.
The function `clar_sandbox()` can fail either because it failed to build a sandbox path or because it failed to change directories into it. The error reporting happens at the callsite of this function though, where we are unable to distinguish those two root causes. Adapt the code to instead perform error handling via `clar_abort()` in `clar_sandbox()` itself. This gives us direct access to the root cause. Callers do not need to check for errors anymore.
We're not consistently checking for failing calls to `calloc()`. Do so and adapt all callsites to use `clar_abort()`.
We're not checking for failing calls to `strdup()`. Fix this.
We have a single callsite of `assert()` remaining in our codebase that checks for unknown command line arguments. This is somewhat broken though as asserts may not be compiled depending on how the code is compiled. Consequently, we may not abort properly on invalid arguments in some scenarios. Fix this issue by using `clar_abort()` instead.
pks-t
force-pushed
the
pks-clar-abort
branch
from
2af3e8d
to
eaefd95
Compare
|
Rebased on top of #100. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failures are being treated somewhat inconsistently throughout the clar codebase. Introduce a new function
clar_abort()and adapt our error handling to use it consistently.