Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curation for npm applicationinsights-core-js #29248

Conversation

devm33
Copy link
Contributor

@devm33 devm33 commented Jan 27, 2025

@capfei
Copy link
Member

capfei commented Jan 28, 2025

@devm33 Thank you for the contribution! Can you update the spacing to be 2 instead of 4? We use 2. Same for #29249 and #29250.

If not, that's ok. I can fix it after merging. Thank you!

@capfei capfei added the feedback requested Unclear curation. PRs with this label will be closed after 60 days if no activity. label Jan 28, 2025
@capfei capfei self-assigned this Jan 28, 2025
@devm33
Copy link
Contributor Author

devm33 commented Jan 29, 2025

@devm33 Thank you for the contribution! Can you update the spacing to be 2 instead of 4? We use 2. Same for #29249 and #29250.

If not, that's ok. I can fix it after merging. Thank you!

Done. FWIW these PRs were created with tooling from GitHub, so maybe worth tracking that down to avoid the issue

@capfei capfei merged commit a1bbba1 into clearlydefined:master Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback requested Unclear curation. PRs with this label will be closed after 60 days if no activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants