Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put Stringbuilder-based code inside clj block #86

Merged

Conversation

Joseph-Alley
Copy link
Contributor

The hickory cljc file uses Stringbuilder, even though it is java code. The relevant function is only ever called from clj, but its existence in the cljc file causes some cljs compilation warnings.

This PR puts that code inside a clj block, to prevent warnings.

Note the code would be nicer if we removed the clj-html-escape-without-quoin function entirely, since it exists only to be called within html-escape, which already uses a clj block. However, I didn't want to break the functionality for any users who might be calling clj-html-escape-without-quoin directly, for some reason.

@danielcompton danielcompton merged commit 2584e89 into clj-commons:master Dec 21, 2023
@danielcompton
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants