Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest deps #210

Merged
merged 3 commits into from
Dec 14, 2017
Merged

Latest deps #210

merged 3 commits into from
Dec 14, 2017

Conversation

dotemacs
Copy link
Contributor

@dotemacs dotemacs commented Dec 8, 2017

Upgraded Clojure 1.9.0-xyz to the latest 1.9.0 release.

Checklist

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (run lein do clean, test)
  • Code inlining with mranderson works and tests pass with inlined code (run ./build.sh install -- takes a long time)

Seeing as Clojure 1.9.0 is officially out, dependency upgraded
@dotemacs
Copy link
Contributor Author

dotemacs commented Dec 8, 2017

1/3 test runs fails.

The test with openjdk7 is the culprit:

https://travis-ci.org/clojure-emacs/refactor-nrepl/jobs/313733211

@dotemacs
Copy link
Contributor Author

dotemacs commented Dec 8, 2017

Also, noticed that TravisCI supports oraclejdk9 as one of the build JDKs.
Should I add it to .travisci ?

@dotemacs
Copy link
Contributor Author

dotemacs commented Dec 9, 2017

In the previous push, I upgraded Clojure 1.9.0-alpha17 -> 1.9.0 and ClojureScript 1.9.671 -> 1.9.946, which caused the build failure with openjdk7, with this exception:

Exception in thread "main" java.lang.UnsupportedClassVersionError: com/google/javascript/jscomp/CompilerOptions : Unsupported major.minor version 52.0, compiling:(cljs/externs.clj:1:1)

Reverted back the ClojureScript upgrade and the tests passed.

@benedekfazekas
Copy link
Member

ta! will have a look

@dotemacs
Copy link
Contributor Author

dotemacs commented Dec 9, 2017

Adding oraclejdk9 to .travisci results in the following failure:
https://travis-ci.org/clojure-emacs/refactor-nrepl/jobs/313884026

Exception in thread "main" java.lang.ClassNotFoundException: sun.misc.Launcher, compiling:(mranderson048/alembic/v0v3v2/dynapath/v0v2v3/dynapath/defaults.clj:29:3)

Which is related to this classloader issue tobias/clojure-java-9#3

@dotemacs
Copy link
Contributor Author

dotemacs commented Dec 9, 2017

I'll remove the addition of oraclejdk9 from .travisci.

I'll just try to see how much upward movement I can get by upgrading ClojureScript from the current 1.9.671 as there are the following releases since:

  • 1.9.854
  • 1.9.908
  • 1.9.946

Upgraded by one release, since upgrading to the very latest release,
breaks the build on openjdk7 on TravisCI. So trying to do it release
by release.
@dotemacs
Copy link
Contributor Author

dotemacs commented Dec 9, 2017

Upgraded ClojureScript to 1.9.854, the tests passed:

https://travis-ci.org/clojure-emacs/refactor-nrepl/builds/314060527

Will try the next release...

Doing the upgrade incrementally, going to the next release and seeing
if it breaks the build.
@dotemacs
Copy link
Contributor Author

dotemacs commented Dec 9, 2017

With ClojureScript 1.9.908 the tests pass:

https://travis-ci.org/clojure-emacs/refactor-nrepl/builds/314065470

But with the latest ClojureScript release 1.9.946, as shown above:

5f16bc5

the tests fail:

https://travis-ci.org/clojure-emacs/refactor-nrepl/jobs/313733211

What would you like to do?

@benedekfazekas benedekfazekas merged commit f2e3fd5 into clojure-emacs:master Dec 14, 2017
@benedekfazekas
Copy link
Member

just went with cljs that works. ta!

@dotemacs dotemacs deleted the latest-deps branch December 14, 2017 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants