Allow keeping bool return values #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyMI contains a workaround to avoid returning boolean values for void MI functions, mostly in an attempt to remain compatible with other WMI libraries. The problem is that we're losing boolean return values. We could just drop the workaround and let PyMI return boolean values even for void functions, however that might break some applications. Instead, we'll add an optional argument called "keep_bool_ret_vals", which can explicitly request the boolean return values to be preserved.
|
LGTM. |
ader1990
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyMI contains a workaround to avoid returning boolean values for void MI functions, mostly in an attempt to remain compatible with other WMI libraries.
The problem is that we're losing all boolean return values. We could just drop the workaround and let PyMI return boolean values even for void functions, however that might break some applications.
Instead, we'll add an optional argument called "keep_bool_ret_vals", which can explicitly request the boolean return values to be preserved.