Allow suppressing timestamps in logs #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having double timestamps when running under systemd makes no sense: ``` $ sudo journalctl -n 4 -u ebpf_exporter Jul 20 04:37:36 vm ebpf_exporter[23736]: 2023/07/20 04:37:36 Started with capabilities: "cap_syslog,cap_perfmon,cap_bpf=eip" Jul 20 04:37:36 vm ebpf_exporter[23736]: 2023/07/20 04:37:36 Dropped capabilities to "cap_syslog=ep" Jul 20 04:37:36 vm ebpf_exporter[23736]: 2023/07/20 04:37:36 Started with 1 programs found in the config in 15ms Jul 20 04:37:36 vm ebpf_exporter[23736]: 2023/07/20 04:37:36 Listening on fd://0 ``` With `--log.no-timestamps`: ``` ivan@vm:~/projects/ebpf_exporter$ sudo journalctl -n 4 -u ebpf_exporter Jul 21 00:04:39 vm ebpf_exporter[25099]: Started with capabilities: "cap_syslog,cap_perfmon,cap_bpf=eip" Jul 21 00:04:39 vm ebpf_exporter[25099]: Dropped capabilities to "cap_syslog=ep" Jul 21 00:04:39 vm ebpf_exporter[25099]: Started with 1 programs found in the config in 16ms Jul 21 00:04:39 vm ebpf_exporter[25099]: Listening on fd://0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having double timestamps when running under systemd makes no sense:
With
--log.no-timestamps: