-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: prevent bundling entire package.json
in built code
#6753
Conversation
🦋 Changeset detectedLatest commit: 26715c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10928000964/npm-package-wrangler-6753 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6753/npm-package-wrangler-6753 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10928000964/npm-package-wrangler-6753 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10928000964/npm-package-create-cloudflare-6753 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10928000964/npm-package-cloudflare-kv-asset-handler-6753 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10928000964/npm-package-miniflare-6753 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10928000964/npm-package-cloudflare-pages-shared-6753 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10928000964/npm-package-cloudflare-vitest-pool-workers-6753 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10928000964/npm-package-cloudflare-workers-editor-shared-6753 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10928000964/npm-package-cloudflare-workers-shared-6753 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this!
Congratulations @bluwy, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm1gdjl6n02620cjn0svxj1ut This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
What this PR solves / how to test
Fixes N/A
I noticed that the
package.json
was bundled inwrangler/wrangler-dist/cli.js
. I found that we can simplify thepackage.json
import to prevent that from happening.The
package.json
is used by thecheck-update
dependency, but it only requires thename
andversion
to detect updates: https://github.com/vercel/update-check/blob/4338e215c9d089f46c6edff45ba41941c070d39f/index.js#L169-L201. So we only need to import the name and version to satisfy it.Author has addressed the following