fix: add a missing experimental template to C3 for asset-only Worker #6760
Conversation
🦋 Changeset detectedLatest commit: 5668097 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10992412370/npm-package-wrangler-6760You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6760/npm-package-wrangler-6760Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10992412370/npm-package-wrangler-6760 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10992412370/npm-package-create-cloudflare-6760 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10992412370/npm-package-cloudflare-kv-asset-handler-6760npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10992412370/npm-package-miniflare-6760npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10992412370/npm-package-cloudflare-pages-shared-6760npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10992412370/npm-package-cloudflare-vitest-pool-workers-6760npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10992412370/npm-package-cloudflare-workers-editor-shared-6760npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10992412370/npm-package-cloudflare-workers-shared-6760Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
petebacondarwin
force-pushed
the
add-static-only-c3-template
branch
from
32bfbfb
to
5668097
Compare
| /** | ||
| * Welcome to Cloudflare Workers! This is your first worker. | ||
| * | ||
| * - Run `npm run dev` in your terminal to start a development server | ||
| * - Open a browser tab at http://localhost:8787/ to see your worker in action | ||
| * - Run `npm run deploy` to publish your worker | ||
| * | ||
| * Learn more at https://developers.cloudflare.com/workers/ | ||
| */ |
There was a problem hiding this comment.
Looks like a duplicate of the message above?
| # Logs | ||
|
|
||
| logs | ||
| _.log | ||
| npm-debug.log_ | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| lerna-debug.log* | ||
| .pnpm-debug.log* | ||
|
|
There was a problem hiding this comment.
I just notice that these __dot_gitignore file should be ignored. There is already an entry to ignore all of these on templates so you probably need to add one more for the templates-experimental:
# Already in .gitignore
templates/**/__dot__gitignore
# I think we should add this
templates-experimental/**/__dot__gitignoreWe might have it added with other experimental templates too. So it would be great if you can remove them as well. 👍🏼
|
Oops sorry @edmundhung - I merged it before I saw your review. I'll follow up now with another PR. |
What this PR solves / how to test
Fixes N/A
Author has addressed the following