Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wrangler): Error if Workers + Assets are run in remote mode #6778

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Sep 19, 2024

What this PR solves / how to test

Workers + Assets are currently supported only in local mode. We should throw an error if users attempt to use Workers with assets in remote mode.

Screenshot 2024-09-19 at 20 54 26

Fixes WC-2743

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: covered by unit tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not documented

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner September 19, 2024 18:55
Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: d80473e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-wrangler-6778

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6778/npm-package-wrangler-6778

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-wrangler-6778 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-create-cloudflare-6778 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-cloudflare-kv-asset-handler-6778
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-miniflare-6778
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-cloudflare-pages-shared-6778
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-cloudflare-vitest-pool-workers-6778
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-cloudflare-workers-editor-shared-6778
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-cloudflare-workers-shared-6778

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.4
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Member

@GregBrimble GregBrimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We'll just need to remember to rename "Experimental Assets" to "Assets" when we flip that over.

Workers + Assets are currently supported only in local mode.
We should throw an error if users attempt to use Workers
with assets in remote mode.
packages/wrangler/src/__tests__/dev.test.tsx Outdated Show resolved Hide resolved
packages/wrangler/src/experimental-assets.ts Outdated Show resolved Hide resolved
@edmundhung edmundhung merged commit 61dd93a into main Sep 20, 2024
22 checks passed
@edmundhung edmundhung deleted the carmen/wa-fast-follows branch September 20, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants