-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wrangler): Error if Workers + Assets are run in remote mode #6778
Conversation
🦋 Changeset detectedLatest commit: d80473e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-wrangler-6778 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6778/npm-package-wrangler-6778 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-wrangler-6778 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-create-cloudflare-6778 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-cloudflare-kv-asset-handler-6778 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-miniflare-6778 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-cloudflare-pages-shared-6778 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-cloudflare-vitest-pool-workers-6778 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-cloudflare-workers-editor-shared-6778 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10955880008/npm-package-cloudflare-workers-shared-6778 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! We'll just need to remember to rename "Experimental Assets" to "Assets" when we flip that over.
Workers + Assets are currently supported only in local mode. We should throw an error if users attempt to use Workers with assets in remote mode.
73083e7
to
33ac536
Compare
What this PR solves / how to test
Workers + Assets are currently supported only in local mode. We should throw an error if users attempt to use Workers with assets in remote mode.
Fixes WC-2743
Author has addressed the following