Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for binding to named entrypoints in the same Worker #8206

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jamesopstad
Copy link
Contributor

Fixes #000

This adds support for binding to named entrypoints in the same Worker.

Additionally, this adds cloudflare:workers imports to the node-compat/worker-basic playground so that we have tests to confirm that Cloudflare builtins can be used when nodejs_compat is enabled.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: N/A
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: N/A

@jamesopstad jamesopstad added the vite-plugin Relating to the `@cloudflare/vite-plugin` package label Feb 20, 2025
@jamesopstad jamesopstad requested review from a team as code owners February 20, 2025 12:57
Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: b40d321

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 20, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-wrangler-8206

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8206/npm-package-wrangler-8206

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-wrangler-8206 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-workers-bindings-extension-8206 -O ./cloudflare-workers-bindings-extension.0.0.0-v01f609f96.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v01f609f96.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-create-cloudflare-8206 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-kv-asset-handler-8206

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-miniflare-8206

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-pages-shared-8206

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-unenv-preset-8206

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-vite-plugin-8206

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-vitest-pool-workers-8206

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-workers-editor-shared-8206

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-workers-shared-8206

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-workflows-shared-8206

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.0
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@jamesopstad jamesopstad changed the title James/same worker service bindings Add support for binding to named entrypoints in the same Worker Feb 20, 2025
@@ -0,0 +1,5 @@
---
"@cloudflare/vite-plugin": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be minor. It's a feature, not a bug fix, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what was agreed in the meeting yesterday for beta and 0.x.x packages.

Minor for breaking changes, patch for bug fixes and new backwards-compatible features

"@cloudflare/vite-plugin": patch
---

Add support for binding to named entrypoints in the same worker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need a patch changeset for fixing the bug around cloudflare:workers not being treated as a builtin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't fix that. I have another one incoming.

@jamesopstad jamesopstad force-pushed the james/same-worker-service-bindings branch from db60daf to b40d321 Compare February 20, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vite-plugin Relating to the `@cloudflare/vite-plugin` package
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants