-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for binding to named entrypoints in the same Worker #8206
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: b40d321 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-wrangler-8206 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8206/npm-package-wrangler-8206 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-wrangler-8206 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-workers-bindings-extension-8206 -O ./cloudflare-workers-bindings-extension.0.0.0-v01f609f96.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v01f609f96.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-create-cloudflare-8206 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-kv-asset-handler-8206 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-miniflare-8206 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-pages-shared-8206 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-unenv-preset-8206 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-vite-plugin-8206 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-vitest-pool-workers-8206 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-workers-editor-shared-8206 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-workers-shared-8206 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13442894405/npm-package-cloudflare-workflows-shared-8206 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@@ -0,0 +1,5 @@ | |||
--- | |||
"@cloudflare/vite-plugin": patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be minor. It's a feature, not a bug fix, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what was agreed in the meeting yesterday for beta and 0.x.x
packages.
Minor for breaking changes, patch for bug fixes and new backwards-compatible features
"@cloudflare/vite-plugin": patch | ||
--- | ||
|
||
Add support for binding to named entrypoints in the same worker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need a patch changeset for fixing the bug around cloudflare:workers
not being treated as a builtin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR doesn't fix that. I have another one incoming.
db60daf
to
b40d321
Compare
Fixes #000
This adds support for binding to named entrypoints in the same Worker.
Additionally, this adds
cloudflare:workers
imports to thenode-compat/worker-basic
playground so that we have tests to confirm that Cloudflare builtins can be used whennodejs_compat
is enabled.