fix: make vitest-pool-workers not crash with scripts that have Workflows #8208
+229
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because `vitest-pool-workers` uses its runner worker as the entrypoint and not the user provided worker. The user provided worker is loaded AFAICT though eval (`vitest-pool-workers` enables eval) so we need, at startup time, to add the required entrypoints and make them dynamically call the user one. Not only that, if you try to create a workflow instance it would throw a `isolated storage` error - I suspect that is this caused by engine still being active at the end of the test (since workflows are async, not in the request path, and might take undefinite time to complete). In order to fix this, I've bypassed the isolated storage check for workflows internal DOs. I wonder if there might be collisions between test files if there are any concurrency regarding test files (aka `singleWorker` is false) - I think that this is fine to do, the point of this PR is not to make workflows really testable yet but to at least to make `vitest-pool-workers` **not** crash if a user includes a workflow in the worker definition.
🦋 Changeset detectedLatest commit: dce74d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-wrangler-8208You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8208/npm-package-wrangler-8208Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-wrangler-8208 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-cloudflare-workers-bindings-extension-8208 -O ./cloudflare-workers-bindings-extension.0.0.0-v8fb8f5f19.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v8fb8f5f19.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-create-cloudflare-8208 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-cloudflare-kv-asset-handler-8208miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-miniflare-8208@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-cloudflare-pages-shared-8208@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-cloudflare-unenv-preset-8208@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-cloudflare-vite-plugin-8208@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-cloudflare-vitest-pool-workers-8208@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-cloudflare-workers-editor-shared-8208@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-cloudflare-workers-shared-8208@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13455342618/npm-package-cloudflare-workflows-shared-8208Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
vitest-pool-workersuses its runner worker as the entrypoint and not the user provided worker. The user provided worker is loaded AFAICT though eval (vitest-pool-workersenables eval) so we need, at startup time, to add the required entrypoints and make them dynamically call the user one.Not only that, if you try to create a workflow instance it would throw a
isolated storageerror - I suspect that is this caused by engine still being active at the end of the test (since workflows are async, not in the request path, and might take undefinite time to complete).In order to fix this, I've bypassed the isolated storage check for workflows internal DOs. I wonder if there might be collisions between test files if there are any concurrency regarding test files (aka
singleWorkeris false) - I think that this is fine to do, the point of this PR is not to make workflows really testable yet but to at least to makevitest-pool-workersnot crash if a user includes a workflow in the worker definition.Fixes #7414.