Add Get and GetCredentials for CFServiceInstances #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klapkov
commented
Nov 11, 2024
| } | ||
|
|
||
| namespace, err := r.namespaceRetriever.NamespaceFor(ctx, secretName, ServiceInstanceResourceType) | ||
| if err != nil { |
There was a problem hiding this comment.
Maybe this is not the best way to do this, because we get the namespace from the service instance. Should we introduce the corev1.Secret Resource here: https://github.com/cloudfoundry/korifi/blob/main/api/repositories/namespace_retriever.go ? This seams the most reasonable approach to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3609
#3608
What is this change about?
Here we expose GET /v3/service_instances/:guid and we also add GET /v3/service_instances/:guid/credentials
Does this PR introduce a breaking change?
No
Acceptance Steps
Tag your pair, your PM, and/or team