refactor: move timing info to extra access log fields logic #455
+27
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
maxmoehl
force-pushed
the
maxmoehl/migrate-detailed-log
branch
from
a6cd99e to
cf78663
Compare
maxmoehl
force-pushed
the
maxmoehl/migrate-detailed-log
branch
from
cf78663 to
a90aef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that we have to ability to add individual log fields I've migrated a set of log fields that was previously behind a special feature flag to use the same logic internally. The feature flag remains but gorouter is no longer aware of it.
The output is identical because the logic for the attempts logging and the dynamic logging is right next to each other. The template ensures that the order of the attempts logging fields is the same as it was previously in the gorouter code.
Backward Compatibility
Breaking Change? No