Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-translation:docs/root/configuration/security/secret.rst #378

Merged
merged 5 commits into from
Dec 24, 2020
Merged

zh-translation:docs/root/configuration/security/secret.rst #378

merged 5 commits into from
Dec 24, 2020

Conversation

majinghe
Copy link

@majinghe majinghe commented Dec 7, 2020

issue: #298

@addozhang
Copy link

为什么分隔符会导致编译出错？

@majinghe
Copy link
Author

为什么分隔符会导致编译出错？

@addozhang 这个也是编译过程积累出来的，当分隔符比上面的中文短的时候，就会报错，提示你分隔符 too short。
Screen Shot 2020-12-11 at 10 35 02 AM

@majinghe
Copy link
Author

@addozhang @helight 晓辉，振文，看一下这个 PR。

helight
helight reviewed Dec 18, 2020
View reviewed changes
docs/root/configuration/security/secret.rst Outdated

If a listener server certificate needs to be fetched by SDS remotely, it will NOT be marked as active, its port will not be opened before the certificates are fetched. If Envoy fails to fetch the certificates due to connection failures, or bad response data, the listener will be marked as active, and the port will be open, but the connection to the port will be reset.
如果需要通过 SDS 来远程获取一个监听器服务器的证书，此监听器将不会被标记为激活状态，在证书被获取之前，它的端口将不会被打开。如果因为连接失败或者错误的返回数据导致 Envoy 获取证书失败，监听器将会被标记为激活状态，而且端口也会被打开，但是此端口的连接将会被重制。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段有点疑惑，获取失败应该被标示为非 active 才对呀

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helight 这个按照原文是这个意思。我创建了一个 issue: #441 。专门存放翻译过程中的疑问。咱们前期翻译还是跟着原文走。等翻译结束，把这些提个 issue 给上游，统一看一下结果。你意下如何？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

@majinghe majinghe requested a review from addozhang December 18, 2020 02:15
helight
helight reviewed Dec 18, 2020
View reviewed changes
Copy link
Member

@helight helight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点建议

@majinghe
Copy link
Author

majinghe commented Dec 21, 2020 •
edited
Loading

@helight 振文，参考进行了修改。你上面的疑惑点，我会把它写到这个issue #441 进行记录。最后统一给社区反应。
另外，这个 secret 翻译不？我最开始想翻译成安全。后来又感觉放着比较好。但是上上周赵化冰老师分享的时候，它的 PPT 里面写的是证书发现服务。这个你怎么看。

@majinghe majinghe requested a review from helight December 22, 2020 00:48
@addozhang
Copy link

@helight 振文，参考进行了修改。你上面的疑惑点，我会把它写到这个issue #441 进行记录。最后统一给社区反应。
另外，这个 secret 翻译不？我最开始想翻译成安全。后来又感觉放着比较好。但是上上周赵化冰老师分享的时候，它的 PPT 里面写的是证书发现服务。这个你怎么看。

secret 翻译成凭证如何？

@helight
Copy link
Member

helight commented Dec 22, 2020

LGTM

@majinghe
Copy link
Author

@helight 振文，参考进行了修改。你上面的疑惑点，我会把它写到这个issue #441 进行记录。最后统一给社区反应。
另外，这个 secret 翻译不？我最开始想翻译成安全。后来又感觉放着比较好。但是上上周赵化冰老师分享的时候，它的 PPT 里面写的是证书发现服务。这个你怎么看。

secret 翻译成凭证如何？

但是里面通篇几乎都是证书，要不就翻译成证书？

@addozhang
Copy link

@helight 振文，参考进行了修改。你上面的疑惑点，我会把它写到这个issue #441 进行记录。最后统一给社区反应。
另外，这个 secret 翻译不？我最开始想翻译成安全。后来又感觉放着比较好。但是上上周赵化冰老师分享的时候，它的 PPT 里面写的是证书发现服务。这个你怎么看。

secret 翻译成凭证如何？

但是里面通篇几乎都是证书，要不就翻译成证书？

也可以

@majinghe
Copy link
Author

@addozhang 晓辉 看一下这个 PR，还有没有需要修改的地方。

addozhang
addozhang approved these changes Dec 23, 2020
View reviewed changes
Copy link

@addozhang addozhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@majinghe majinghe merged commit 0d0d1e8 into cloudnativeto:zh Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addozhang addozhang addozhang approved these changes

@helight helight Awaiting requested review from helight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majinghe @addozhang @helight