Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): IsRunning returns true when it's ready #1301

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

xiaost
Copy link
Contributor

@xiaost xiaost commented Mar 14, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

IsRunning() 方法现在只有在可以监听时,才会返回 true

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:

  • added Listener() method for network transport
  • check Listener() in IsRunning()

zh(optional):

(Optional) Which issue(s) this PR fixes:

(Optional) The PR that updates user documentation:

@xiaost xiaost requested review from a team as code owners March 14, 2025 10:36
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.32%. Comparing base (00ed124) to head (81e2ea3).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1301      +/-   ##
===========================================
+ Coverage    72.23%   72.32%   +0.08%     
===========================================
  Files          138      138              
  Lines        16139    16185      +46     
===========================================
+ Hits         11658    11705      +47     
+ Misses        3886     3885       -1     
  Partials       595      595              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* added Listener() method for network transport
* check Listener() in IsRunning()
@xiaost xiaost merged commit bee9460 into develop Mar 17, 2025
40 of 44 checks passed
@xiaost xiaost deleted the fix-is-running branch March 17, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants