Skip to content

Commit

Permalink
Merge pull request #16 from cmungall/issue-12-comments
Browse files Browse the repository at this point in the history
rem field usage comments for #12
  • Loading branch information
turbomam authored Jan 11, 2022
2 parents 391489a + 09c9c4f commit 1a71a2a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 12 deletions.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ gen: $(patsubst %,gen-%,$(TGTS))
clean:
rm -rf target/
rm -f env.lock
rm -rf downloads/mixs6*
rm -f model/schema/mixs.yaml
# pipenv --rm
.PHONY: clean

Expand Down
24 changes: 12 additions & 12 deletions gsctools/mixs_converter.py
Original file line number Diff line number Diff line change
Expand Up @@ -423,18 +423,18 @@ def convert(self) -> Dict[str, Any]:
if s_id not in core_slots:
c['slots'].append(s_id)

n_cls = len(cls_slot_req.keys())
inf_core_slots = []
for s_id, s in slot_cls_req.items():
packages_str = ', '.join(list(s.keys()))
if len(s.keys()) == n_cls:
inf_core_slots.append(s_id)
cmt = "This field is used in all packages"
elif len(s.keys()) == 1:
cmt = f"This field is used uniquely in: {packages_str}"
else:
cmt = f"This field is used in: {len(s.keys())} packages: {packages_str}"
slots[s_id]['comments'].append(cmt)
# n_cls = len(cls_slot_req.keys())
# inf_core_slots = []
# for s_id, s in slot_cls_req.items():
# packages_str = ', '.join(list(s.keys()))
# if len(s.keys()) == n_cls:
# inf_core_slots.append(s_id)
# cmt = "This field is used in all packages"
# elif len(s.keys()) == 1:
# cmt = f"This field is used uniquely in: {packages_str}"
# else:
# cmt = f"This field is used in: {len(s.keys())} packages: {packages_str}"
# slots[s_id]['comments'].append(cmt)


for p in env_packages:
Expand Down

0 comments on commit 1a71a2a

Please sign in to comment.