Thanos LFX 2025 Term 1 project idea #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add our project idea. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
add_our_project
branch
from
4a5a1b1 to
82e27fc
Compare
saswatamcode
approved these changes
Feb 4, 2025
MichaHoffmann
approved these changes
Feb 4, 2025
nate-double-u
changed the title
nate-double-u
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Thanks for this @GiedriusS and @saswatamcode (and Thanos team!)
I'm approving this now but will merge it a bit later (need to batch moving things over to LFX).
|
Hi @GiedriusS, sorry about this, I tried to clear the conflict on this, but wasn't able to push. Could you take a look? |
|
Cool, the conflict went away with another PR, so I've merged this in. Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add our project idea.