kvserver: better obs in TestTxnReadWithinUncertaintyIntervalAfterRangeMerge #143270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
…eMerge This is a complex test with a rare failure mode. Trace all of the relevant operations so that we can meaningfully engage with it. Epic: none Release note: none
tbg
force-pushed
the
TestTxnReadWithinUncertaintyIntervalAfterRangeMerge-143260
branch
from
d81ea55 to
03bf83c
Compare
stevendanna
approved these changes
Mar 24, 2025
| @@ -1545,6 +1545,18 @@ func (t Transaction) SafeFormat(w redact.SafePrinter, _ rune) { | |||
| } | |||
| w.Printf("meta={%s} lock=%t stat=%s rts=%s wto=%t gul=%s", | |||
| t.TxnMeta, t.IsLocking(), t.Status, t.ReadTimestamp, t.WriteTooOld, t.GlobalUncertaintyLimit) | |||
| for i, obs := range t.ObservedTimestamps { | |||
There was a problem hiding this comment.
I'm honestly surprised the test impact of this change isn't larger. It would be nice if SafeFormat also passed us the modifiers, because then we could do thinks like only do this for +v instead of just v. Anyway, that isn't for this PR.
For this PR, do you think it would make sense to truncate this if there was a very large number of nodes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143260.
This is a complex test with a rare failure mode. Trace all of the relevant operations so that we can meaningfully engage with it.
Epic: none
Release note: none