kvclient: fix small bug in txnWriteBuffer #143304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
Nice find! I have a suggestion but
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @arulajmani)
pkg/kv/kvclient/kvcoord/txn_interceptor_write_buffer.go line 514 at r1 (raw file):
) (*roachpb.Value, bool) { it := twb.buffer.MakeIter() seek := &twb.bufferSeek
I think we might need to do the same in addToBuffer, no? Should we extract a helper method that would return "buffer seek" set to appropriate start key and - if applicable - end key? I.e. let's centralize the mutation of reused bufferSeek struct.
Previously, we were not resetting the endKey before starting our iteration. This could result in the iterator ending before reaching our desired key despite it being in the buffer. Epic: none Release note: None
stevendanna
force-pushed
the
ssd/write-buffer-smol-bug
branch
from
8ac3b5d to
7c03dcf
Compare
|
bors r=yuzefovich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were not resetting the endKey before starting our iteration. This could result in the iterator ending before reaching our desired key despite it being in the buffer.
Epic: none
Release note: None