Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.2: explain: fix decoding plan gist with CALL stmts #143312

Merged
merged 1 commit into from
Mar 24, 2025
Merged

release-23.2: explain: fix decoding plan gist with CALL stmts #143312

merged 1 commit into from
Mar 24, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 22, 2025 •
edited by yuzefovich
Loading

Backport 1/1 commits from #143252 on behalf of @yuzefovich.

/cc @cockroachdb/release

Previously we'd hit a nil pointer error when trying to print Proc argument when it is nil. The problem is that it is stored as *tree.RoutineExpr, and (*tree.RoutineExpr)(nil) is different from (tree.TypedExpr)(nil) that we check for (and short-circuit on) in the Expr call.

I have an idea for how we could've caught this, but it'll be done in a separate commit.

Fixes: #143211.

Release note (bug fix): CockroachDB would previously encounter an internal error when decoding plan gists of the plans with CALL statements. The bug has been present since 23.2 version and is now fixed.

Release justification: bug fix.

@yuzefovich
explain: fix decoding plan gist with CALL stmts
1c74e4d 
Previously we'd hit a nil pointer error when trying to print `Proc`
argument when it is `nil`. The problem is that it is stored as
`*tree.RoutineExpr`, and `(*tree.RoutineExpr)(nil)` is different from
`(tree.TypedExpr)(nil)` that we check for (and short-circuit on) in the
`Expr` call.

I have an idea for how we could've caught this, but it'll be done in a
separate commit.

Release note (bug fix): CockroachDB would previously encounter an
internal error when decoding plan gists of the plans with CALL
statements. The bug has been present since 23.2 version and is now
fixed.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-143252 branch from e9e073b to 1c74e4d Compare March 22, 2025 00:56
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 22, 2025 00:56
@blathers-crl blathers-crl bot requested review from mw5h and removed request for a team March 22, 2025 00:56
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 22, 2025
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Mar 22, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot requested review from DrewKimball and mgartner March 22, 2025 00:56
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Mar 22, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich merged commit 2140afb into release-23.2 Mar 24, 2025
5 of 6 checks passed
@yuzefovich yuzefovich deleted the blathers/backport-release-23.2-143252 branch March 24, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgartner mgartner mgartner approved these changes

@mw5h mw5h Awaiting requested review from mw5h mw5h is a code owner automatically assigned from cockroachdb/sql-queries-prs

@DrewKimball DrewKimball Awaiting requested review from DrewKimball

Assignees

@yuzefovich yuzefovich

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-23.2.23
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @mgartner @yuzefovich