sql: use InputCount and Input planNode methods to walk check plans #143464
+17
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
yuzefovich
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @rytaft)
pkg/sql/distsql_running.go line 2582 at r1 (raw file):
return errors.AssertionFailedf("unexpectedly physical plan is used for a parallel CHECK") } // Ignore the error since our observer never returns an error.
nit: this comment is no longer relevant.
The Input and InputCount methods of the planNode interface are now used to walk plan node trees of post-query checks. This continues the effort to deprecate and remove the plan node walkers (see cockroachdb#137620 for more details on the motivation for this). Release note: None
mgartner
force-pushed
the
remove-checks-walk-plan
branch
from
532cb6e to
68e822f
Compare
mgartner
commented
Mar 26, 2025
There was a problem hiding this comment.
Reviewable status:
pkg/sql/distsql_running.go line 2582 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit: this comment is no longer relevant.
Good catch. Done.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: use InputCount and Input planNode methods to walk check plans
The Input and InputCount methods of the planNode interface are now
used to walk plan node trees of post-query checks. This continues the
effort to deprecate and remove the plan node walkers (see #137620 for
more details on the motivation for this).
Epic: None
Release note: None