Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipelineStateChanged performance optimization #15753

Conversation

troublemaker52025
Copy link
Contributor

@troublemaker52025 troublemaker52025 commented Jul 17, 2023

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@troublemaker52025
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -11191,8 +11191,9 @@
                 protected _passes: Pass[] | null;
                 protected _shaders: gfx.Shader[] | null;
                 protected _subMesh: RenderingSubMesh | null;
                 protected _patches: IMacroPatch[] | null;
+                protected _globalPatches: MacroRecord | null;
                 protected _priority: pipeline.RenderPriority;
                 protected _inputAssembler: gfx.InputAssembler | null;
                 protected _descriptorSet: gfx.DescriptorSet | null;
                 protected _worldBoundDescriptorSet: gfx.DescriptorSet | null;

@github-actions
Copy link

@troublemaker52025, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
ios FAIL FAIL
android PASS PASS FAIL rich-text-long-string-truncation
mac PASS PASS PASS

@github-actions
Copy link

@troublemaker52025, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios FAIL FAIL
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS FAIL particle-rotation particle-rotation

@jk20012001 jk20012001 merged commit 4b26cc8 into cocos:v3.8.1 Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants