Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove _fitDesignResolution function call in EVENT_AFTER_UPDATE #15802

Merged

Conversation

moshuying
Copy link
Contributor

@moshuying moshuying commented Jul 21, 2023

Re: # https://github.com/cocos/3d-tasks/issues/17320
https://github.com/cocos/3d-tasks/issues/17320

Changelog

  • Canvas switched to using Widgets, but forgot to clean up the previous alignment logic, resulting in duplicates. Cleanup required.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@moshuying moshuying requested a review from SantyWang July 21, 2023 09:24
@moshuying moshuying changed the base branch from develop to v3.8.1 July 21, 2023 09:40
@github-actions
Copy link

@moshuying, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL object-group-image,puzzle,shield-node,label-cacheMode,label-align,ttf-font
ios FAIL FAIL
android PASS PASS FAIL object-group-image,puzzle,shield-node,rich-text-long-string-truncation
mac PASS PASS FAIL object-group-image,puzzle,shield-node

@moshuying
Copy link
Contributor Author

@cocos-robot run test cases

@moshuying moshuying closed this Jul 24, 2023
@moshuying moshuying reopened this Jul 24, 2023
@github-actions
Copy link

@moshuying, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios FAIL FAIL
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS FAIL particle-rotation particle-rotation

@github-actions
Copy link

@moshuying, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL particle-rotation,particle-size,label-cacheMode,label-align,ttf-font
ios FAIL PASS FAIL particle-rotation,particle-size
android PASS PASS FAIL particle-rotation particle-rotation
mac PASS PASS FAIL particle-rotation particle-rotation

@moshuying moshuying changed the title remove _fitDesignResolution function remove _fitDesignResolution function call in EVENT_AFTER_UPDATE Jul 25, 2023
@moshuying moshuying force-pushed the fix-can't-adjust-the-2D-camera-in-editor branch from d047fe9 to c7759aa Compare July 26, 2023 11:31
@moshuying moshuying closed this Aug 2, 2023
@moshuying moshuying reopened this Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

@moshuying ❗ There was an error during the execution of the tasks. Please check the logs for more details.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

@moshuying, Please check the result of run test cases:

Task Details

@moshuying moshuying closed this Aug 7, 2023
@moshuying moshuying reopened this Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

@moshuying, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL
android PASS PASS FAIL rich-text-long-string-truncation
mac PASS PASS PASS

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

@moshuying, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL
android PASS PASS FAIL rich-text-long-string-truncation
mac PASS PASS PASS

@SantyWang SantyWang merged commit f55abfa into cocos:v3.8.1 Aug 9, 2023
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants