Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ia pool. #15880

Merged
merged 2 commits into from
Aug 10, 2023
Merged

remove ia pool. #15880

merged 2 commits into from
Aug 10, 2023

Conversation

bluesky013
Copy link
Contributor

@bluesky013 bluesky013 commented Aug 4, 2023

Re: #

Changelog

  • remove ia pool.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bluesky013
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Interface Check Report

This pull request does not change any public interfaces !

@bluesky013 bluesky013 changed the title remote ia pool. remove ia pool. Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

@bluesky013, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
windows PASS PASS FAIL planar-shadow,material-upgrade,label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL
android PASS PASS FAIL planar-shadow,material-upgrade,rich-text-long-string-truncation
mac PASS PASS FAIL planar-shadow,material-upgrade

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

@bluesky013, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL planar-shadow,material-upgrade,label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL
android PASS PASS FAIL planar-shadow,material-upgrade,rich-text-long-string-truncation
mac PASS PASS FAIL planar-shadow,material-upgrade

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

@bluesky013, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL
android PASS PASS FAIL rich-text-long-string-truncation
mac PASS PASS FAIL planar-shadow,material-upgrade

@SantyWang
Copy link
Contributor

How about the performance? and InputAssembler has its own allocator?

@SantyWang
Copy link
Contributor

Please use cocos-benchmark project(BunnyMark scene) to test 2D performance.

@bluesky013
Copy link
Contributor Author

How about the performance? and InputAssembler has its own allocator?

The Input Assembler is a container for VertexBuffer and IndexBuffer. In the current 2D scenario, they both share the same VB and IB, so there is no need to create an additional IA for different drawInfo.

The Input Assembler should not be coupled with DrawInfo. Set drawInfo interface will be deprecated in 3.9. The correct usage should be as follows:

bindInputAssembler()
draw(0, 1)
draw(1, 2)
draw(2, 3)

There are no operations that would have a performance impact, and there is no allocator either. The DrawBatch2D simply maintains independent drawInfo.

@bluesky013
Copy link
Contributor Author

bluesky013 commented Aug 7, 2023

cocos-benchmark

currently under testing.

@SantyWang
Copy link
Contributor

The Input Assembler is a container for VertexBuffer and IndexBuffer. In the current 2D scenario, they both share the same VB and IB, so there is no need to create an additional IA for different drawInfo.

The Input Assembler should not be coupled with DrawInfo. Set drawInfo interface will be deprecated in 3.9. The correct usage should be as follows:

bindInputAssembler()
draw(0, 1)
draw(1, 2)
draw(2, 3)
There are no operations that would have a performance impact, and there is no allocator either. The DrawBatch2D simply maintains independent drawInfo.

I see.

@bluesky013
Copy link
Contributor Author

Please use cocos-benchmark project(BunnyMark scene) to test 2D performance.

Tested:
Benchmark: BunnyTest (25000)

Env: Adreno (TM) 642L GLES3.2

f26714d0da1fceef9b01d76cf1c9033

before:
image

after
image

Seems no impact on performance.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

@bluesky013, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL compressWithGray compressWithGray
android PASS PASS FAIL rich-text-long-string-truncation
mac PASS PASS FAIL planar-shadow,material-upgrade

@bluesky013
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

github-actions bot commented Aug 9, 2023

@bluesky013, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS PASS
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
ios FAIL FAIL
android PASS PASS FAIL rich-text-long-string-truncation
mac PASS PASS PASS

@star-e star-e merged commit e69ae56 into cocos:v3.8.1 Aug 10, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants