Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize compiled deserialization related code #15892

Merged
merged 6 commits into from
Aug 8, 2023

Conversation

shrinktofit
Copy link
Contributor

@shrinktofit shrinktofit commented Aug 8, 2023

Re: #

Changelog

  • Typing and optimize compiled deserialize code. Remove commented code. This PR does not change any runtime behavior.

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@shrinktofit shrinktofit changed the title Typing compiled deserialize Optimize compiled deserialization related code Aug 8, 2023
@shrinktofit shrinktofit closed this Aug 8, 2023
cocos/serialization/deserialize.ts Show resolved Hide resolved
cocos/serialization/deserialize.ts Show resolved Hide resolved
cocos/serialization/deserialize.ts Show resolved Hide resolved
cocos/serialization/deserialize.ts Show resolved Hide resolved
cocos/serialization/deserialize.ts Show resolved Hide resolved
cocos/serialization/deserialize.ts Outdated Show resolved Hide resolved
cocos/serialization/deserialize.ts Show resolved Hide resolved
cocos/serialization/deserialize.ts Show resolved Hide resolved
cocos/serialization/deserialize.ts Show resolved Hide resolved
cocos/serialization/deserialize.ts Outdated Show resolved Hide resolved
@shrinktofit shrinktofit reopened this Aug 8, 2023
@VisualSJ VisualSJ merged commit 592432c into cocos:v3.8.1 Aug 8, 2023
9 of 10 checks passed
@shrinktofit shrinktofit deleted the TypingCompiledDeserialize branch August 8, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants