-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3.8.5 ray query #17719
Draft
star-e
wants to merge
106
commits into
cocos:v3.8.5
Choose a base branch
from
star-e:v3.8.5-ray-query
base: v3.8.5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
V3.8.5 ray query #17719
+4,811
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -29143,8 +29143,15 @@
name: string;
count: number;
stageFlags: gfx.ShaderStageFlags;
}
+ export interface IIAccelerationStructureInfp {
+ set: number;
+ binding: number;
+ name: string;
+ count: number;
+ stageFlags: gfx.ShaderStageFlags;
+ }
export interface IAttributeInfo {
name: string;
format: gfx.Format;
isNormalized: boolean;
@@ -29212,8 +29219,9 @@
buffers: IBufferInfo[];
images: IImageInfo[];
subpassInputs: IInputAttachmentInfo[];
descriptors: IDescriptorInfo[];
+ accelerationStructures: IIAccelerationStructureInfp[];
}
export interface IPreCompileInfo {
[name: string]: boolean[] | number[] | string[];
}
|
dumganhar
reviewed
Oct 19, 2024
@@ -120,6 +120,14 @@ export declare namespace EffectAsset { | |||
count: number; | |||
stageFlags: ShaderStageFlags; | |||
} | |||
|
|||
export interface IIAccelerationStructureInfp{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
II -> I ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Infp -> Info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: