support friction float #17742
Closed
support friction float #17742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 Package size ⤵ -24 bytes, old: 5446736, new: 5446712Interface Check ReportThis pull request does not change any public interfaces ! |
dumganhar
reviewed
Oct 19, 2024
| return this._restitution; | ||
| } | ||
|
|
||
| set restitution (value) { | ||
| set restitution(value) { | ||
| if (!math.equals(this._restitution, value)) { |
There was a problem hiding this comment.
Do we also need to fix _restitution here since it's also a float?
dumganhar
reviewed
Oct 19, 2024
| return this._friction; | ||
| } | ||
|
|
||
| set friction (value) { | ||
| if (!math.equals(this._friction, value)) { |
There was a problem hiding this comment.
Perhaps, we need to check whether the value is changed by math.approx rather than math.equals.
Because if value is not changed, the PhysicsMaterial.EVENT_UPDATE event should not be emitted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support friction float