Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support friction CCFLOAT #17761

Open
wants to merge 1 commit into
base: v3.8.5
Choose a base branch
from

Conversation

longchuan
Copy link
Contributor

Re: #

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

👍 Package size ⤵ -87 bytes, old: 5445998, new: 5445911

Interface Check Report

This pull request does not change any public interfaces !

@minggo
Copy link
Contributor

minggo commented Nov 1, 2024

Current implementation also supports float though it is strict equal. What's wrong with current implementation?

@longchuan
Copy link
Contributor Author

longchuan commented Nov 1, 2024

Current implementation also supports float though it is strict equal. What's wrong with current implementation?

js' float support many dots,and bullet's float support many dots too.if the friction was bigger than one,the friction could be max,So,the dots should more than six.Limit the float's dot was meaningless setting.The same problem as position's edit.Editor limits the value,but the scene file has no limits.That is conflictive.

@minggo
Copy link
Contributor

minggo commented Nov 5, 2024

I don't quite understand the issue. Could you give an example to explain it?

@longchuan
Copy link
Contributor Author

I don't quite understand the issue. Could you give an example to explain it?

image
look at this,if I set the friction to 3e-15 or 4e-15,there will have diffrent results.But if I set the friction to 1 or 2,the result will not be different.

@minggo
Copy link
Contributor

minggo commented Nov 6, 2024

1 and 2 should be different.

@longchuan
Copy link
Contributor Author

longchuan commented Nov 6, 2024

1 and 2 should be different.

image
reffer to the requirement, the ball could not output.and blocked by the friction
for the output,the rollingFriction should be a large one.
one friction has one result,I got the different results by editing friction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants