-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reuse _tempVec2 and avoid creating new temple object #17782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@cocos-robot run test cases |
|
@minggo, Please check the result of
Task Details
|
@minggo, Please check the result of
Task Details
|
@cocos-robot run test cases |
qiuguohua
approved these changes
Oct 30, 2024
@cocos-robot run test cases |
1 similar comment
@cocos-robot run test cases |
@minggo, Please check the result of
Task Details |
@minggo, Please check the result of
Task Details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_calculateMovePercentDelta() just uses anchor.x and anchor.y, and will not pass it to other functions, so it is safe to reuse _moveDeltaOptions and _tempVec2.
The best solution is change the parameter from
_calculateMovePercentDelta(options: MoveDeltaOptions)
to_calculateMovePercentDelta(anchor: Vec2, applyToHorizontal: boolean, applyToVertical: boolean)
. Then even don't have to:But it will break the compatibility, as _calculateMovePercentDelta() is a protected function.