-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the problem that particles using gpu keep reporting error. #17824
Conversation
👍 Package size ⤵ -71 bytes, old: 5377715, new: 5377644Interface Check ReportThis pull request does not change any public interfaces ! |
if (useGPU && this.gpuMaterial) { | ||
this.particleMaterial = this.gpuMaterial; | ||
} | ||
this.particleMaterial = useGPU ? this.gpuMaterial : this.cpuMaterial; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should check whether this.particleMaterial
is null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need, after setting, subsequent logic includes checks.
Related API: _onMaterialModified
@knoxHuang, Please check the result of
Task Details |
@knoxHuang, Please check the result of
Task Details |
Re: #17772
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: