Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the problem that particles using gpu keep reporting error. #17824

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

knoxHuang
Copy link
Contributor

@knoxHuang knoxHuang commented Nov 8, 2024

Re: #17772

Changelog

  • Fixed the problem that particles using gpu keep reporting error.
image

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

github-actions bot commented Nov 8, 2024

👍 Package size ⤵ -71 bytes, old: 5377715, new: 5377644

Interface Check Report

This pull request does not change any public interfaces !

@knoxHuang knoxHuang changed the title Fixed the problem that particles using gpu keep reporting error. [not merge]Fixed the problem that particles using gpu keep reporting error. Nov 8, 2024
@knoxHuang knoxHuang changed the title [not merge]Fixed the problem that particles using gpu keep reporting error. Fixed the problem that particles using gpu keep reporting error. Nov 8, 2024
if (useGPU && this.gpuMaterial) {
this.particleMaterial = this.gpuMaterial;
}
this.particleMaterial = useGPU ? this.gpuMaterial : this.cpuMaterial;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check whether this.particleMaterial is null?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need, after setting, subsequent logic includes checks.

Related API: _onMaterialModified

Copy link

@knoxHuang, Please check the result of run test cases:

Task Details

Copy link

@knoxHuang, Please check the result of run test cases:

Task Details

@minggo minggo merged commit 16996b0 into cocos:v3.8.5 Nov 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants