Fix surface-shader #17837
Merged
Fix surface-shader #17837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minggo
reviewed
Nov 11, 2024
| const instanceBuffers = this.instanceBuffers; | ||
| instanceBuffers.forEach((instance) => { | ||
| instance.clear(); | ||
| }); |
There was a problem hiding this comment.
Should also clear instanceBuffers?
There was a problem hiding this comment.
I think gfx instance buffers are reused. They are not recreated every frame.
There was a problem hiding this comment.
The instanceBuffers here will be reused, so there's no need to clear them
There was a problem hiding this comment.
And the size of it is not changed?
There was a problem hiding this comment.
The reuse logic is here： 
star-e
approved these changes
Nov 11, 2024
|
minggo
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.