Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #17833: [v3.8.5] Add an ability to load wasm/asmjs module manually #17844

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

dumganhar
Copy link
Contributor

Re: #17833

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

⚠️ Package size ⤴ 301 bytes, old: 5376474, new: 5376775

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -46863,8 +46863,9 @@
          * @returns @en burst max particle count. @zh 一次最多触发的粒子个数。
          */
         getMaxCount(psys: any): number;
     }
+    export function loadWasmModuleBox2D(): Promise<void>;
     export const Physics2DUtils: {
         PolygonSeparator: typeof __private._cocos_physics_2d_framework_utils_polygon_separator;
         PolygonPartition: typeof __private._cocos_physics_2d_framework_utils_polygon_partition;
     };
@@ -48183,8 +48184,9 @@
          */
         get motorSpeed(): number;
         set motorSpeed(v: number);
     }
+    export function loadWasmModuleBullet(): Promise<void>;
     /**
      * @en
      * The definition of the triggering event.
      * @zh
@@ -48830,8 +48832,9 @@
              * 构造并注册系统单例。
              * 预先加载模块的情况下,会自动执行。
              */
             static constructAndRegister(): void;
+            static constructAndRegisterManually(): Promise<void>;
         }
         /**
          * @en
          * Used to store physics ray test results.
@@ -50884,8 +50887,9 @@
             AABB = 4
         }
         export { ITriggerEvent, TriggerEventType, TriggerCallback, IContactEquation, ICollisionEvent, CollisionEventType, CollisionCallback, CharacterTriggerEventType, CharacterCollisionEventType, CharacterControllerContact };
     }
+    export function loadWasmModulePhysX(): Promise<void>;
     export namespace primitives {
         /**
          * @en
          * This function generates a box with specified extents and centered at origin,
@@ -51562,8 +51566,9 @@
         protected __preload(): void;
         protected _updateSortingPriority(): void;
     }
     export namespace sp {
+        export function loadWasmModuleSpine(): Promise<void>;
         /*
          Copyright (c) 2022-2023 Xiamen Yaji Software Co., Ltd.
         
          https://www.cocos.com/
@@ -58985,8 +58990,9 @@
     export import ERigidBodyType = physics.ERigidBodyType;
     export import EAxisDirection = physics.EAxisDirection;
     export import EColliderType = physics.EColliderType;
     export import EPhysicsDrawFlags = physics.EPhysicsDrawFlags;
+    export import loadWasmModuleSpine = sp.loadWasmModuleSpine;
     export namespace __private {
         /**
          * Engine classes with this kind of signature are integrated with editor extendability.
          * @internal

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL shield-node
ios PASS PASS FAIL shield-node
mac PASS PASS FAIL shield-node

Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
windows PASS PASS FAIL shield-node
android PASS PASS FAIL shield-node
wechatgame PASS FAIL FAIL

@dumganhar dumganhar marked this pull request as draft November 13, 2024 09:15
@dumganhar dumganhar marked this pull request as ready for review November 13, 2024 09:15
@dumganhar dumganhar merged commit 21e6d0c into cocos:v3.8.5 Nov 13, 2024
13 checks passed
cocos-robot pushed a commit to cocos-robot/engine that referenced this pull request Nov 13, 2024
dumganhar pushed a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants