refactored builtin-pipeline #17860
Open
refactored builtin-pipeline #17860
+1,970
−1,403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cocos-robot run test cases |
|
@cocos-robot run test cases |
✅ Package size is not changedInterface Check Report! WARNING this pull request has changed these public interfaces:
@@ -37122,11 +37122,8 @@
}
export interface PipelinePassBuilder {
getConfigOrder(): number;
getRenderOrder(): number;
- resetCamera?(cameraConfigs: {
- [name: string]: any;
- }): void;
configCamera?(camera: Readonly<renderer.scene.Camera>, pplConfigs: {
readonly [name: string]: any;
}, cameraConfigs: {
[name: string]: any;
|
|
@star-e, Please check the result of
Task Details
|
|
@star-e, Please check the result of
Task Details
|
|
@star-e, Please check the result of
Task Details
|
|
@star-e, Please check the result of
Task Details
|
GengineJS
approved these changes
Nov 15, 2024
dumganhar
reviewed
Nov 15, 2024
| @@ -1660,7 +1660,6 @@ export interface Pipeline extends BasicPipeline { | |||
| export interface PipelinePassBuilder { | |||
| getConfigOrder (): number; | |||
| getRenderOrder (): number; | |||
| resetCamera? (cameraConfigs: { [name: string]: any }): void; | |||
There was a problem hiding this comment.
Will removing the public interface resetCamera cause compatibility issue?
There was a problem hiding this comment.
resetCamera is newly added in 3.8.5. So remove it will not cause problem
dumganhar
reviewed
Nov 15, 2024
| outputRadianceName: string, | ||
| ): rendering.BasicRenderPassBuilder { | ||
| this._cocParams.x = this._minRange; | ||
| this._cocParams.y = this._maxRange;// camera.farClip;// this._focusRange; |
There was a problem hiding this comment.
What does the comment // camera.farClip;// this._focusRange; mean?
Could it be removed?
dumganhar
reviewed
Nov 15, 2024
| @@ -137,1295 +123,1656 @@ function setupPipelineConfigs( | |||
| configs.platform.w = (screenSpaceSignY * 0.5 + 0.5) << 1 | (device.capabilities.clipSpaceSignY * 0.5 + 0.5); | |||
| } | |||
|
|
|||
| export interface PipelineSettings2 extends PipelineSettings { | |||
| _passes?: rendering.PipelinePassBuilder[]; | |||
There was a problem hiding this comment.
Will _passes be designed as a private property?
I found that all properties in PipelineSettings do not have a _ prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: