fix: video url type error (#393)

* fix: video url type error * fix: add video repeater validation rules
code4romania · Aug 8, 2024 · 7a00a83 · 7a00a83
1 parent 24ef181
commit 7a00a83
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/app/Filament/Resources/ProjectResource.php b/app/Filament/Resources/ProjectResource.php
@@ -139,9 +139,12 @@ function (callable $get) {
                     ->image()
                     ->multiple()
                     ->maxFiles(20),
-                Forms\Components\Repeater::make('videos')->schema([
-                    TextInput::make('url'),
-                ]),
+                Forms\Components\Repeater::make('videos')
+                    ->schema([
+                        TextInput::make('url')
+                            ->url()
+                            ->required(),
+                    ]),
                 Forms\Components\Repeater::make('external_links')->schema([
                     TextInput::make('title')
                         ->required(),

diff --git a/app/Models/Project.php b/app/Models/Project.php
@@ -21,6 +21,7 @@
 use Illuminate\Database\Eloquent\Relations\HasManyThrough;
 use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Facades\Vite;
+use Illuminate\Support\Str;
 use Spatie\Activitylog\LogOptions;
 use Spatie\Activitylog\Traits\LogsActivity;
 use Spatie\Image\Manipulations;
@@ -241,7 +242,7 @@ public function getVisibleStatusAttribute(): string
 
     public function markAsApproved(): bool
     {
-        $slug = \Str::slug($this->name);
+        $slug = Str::slug($this->name);
 
         $count = self::whereRaw("slug RLIKE '^{$this->slug}(-[0-9]+)?$'")->count();
         if ($count > 0) {
@@ -275,11 +276,12 @@ public function getEmbeddedVideosAttribute(): array
     {
         return collect($this->videos)
             ->pluck('url')
+            ->filter()
             ->map(
                 fn (string $videoUrl) => Cache::remember(
                     'video-' . hash('sha256', $videoUrl),
                     MONTH_IN_SECONDS,
-                    fn () => rescue(fn () => (new Embed)->get($videoUrl)->code, '', false)
+                    fn () => rescue(fn () => (new Embed)->get($videoUrl)->code, report: false)
                 )
             )
             ->filter()